Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add RPC docs #1862

Merged
merged 5 commits into from
Feb 28, 2025
Merged

Add RPC docs #1862

merged 5 commits into from
Feb 28, 2025

Conversation

cb-jake
Copy link
Contributor

@cb-jake cb-jake commented Feb 27, 2025

What changed? Why?

  • Alphabetize RPC sidebar
  • Add docs for wallet_addSubAccount
  • Add docs for wallet_connect

Notes to reviewers

Smart Wallet docs update

How has it been tested?

Manually

Copy link

vercel bot commented Feb 27, 2025

You must have Developer access to commit code to Coinbase on Vercel. If you contact an administrator and receive Developer access, commit again to see your changes.

Learn more: https://vercel.com/docs/accounts/team-members-and-roles/access-roles#team-level-roles

Copy link

vercel bot commented Feb 27, 2025

@cb-jake is attempting to deploy a commit to the Coinbase Team on Vercel.

A member of the Team first needs to authorize it.

@cb-heimdall
Copy link
Collaborator

cb-heimdall commented Feb 27, 2025

✅ Heimdall Review Status

Requirement Status More Info
Reviews 2/1
Denominator calculation
Show calculation
1 if user is bot 0
1 if user is external 0
From .codeflow.yml 1
Additional review requirements
Show calculation
Max 0
0
From CODEOWNERS 0
Global minimum 0
Max 1
1
1 if commit is unverified 0
Sum 1

@cb-jake cb-jake marked this pull request as ready for review February 27, 2025 20:25
@brendan-defi brendan-defi merged commit 4cdce9e into base:master Feb 28, 2025
4 checks passed
@cb-jake cb-jake deleted the jake/rpc-methods branch February 28, 2025 18:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants